Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug in path logic gef-extras.sh #872

Merged
merged 1 commit into from Jul 5, 2022
Merged

fix bug in path logic gef-extras.sh #872

merged 1 commit into from Jul 5, 2022

Conversation

therealdreg
Copy link
Sponsor Collaborator

@therealdreg therealdreg commented Jul 5, 2022

This PR improves and fix a bug in path logic (introduced in #870) (gef-extras.sh)

Now it works with named args (@hugsy suggestion):

./gef-extras.sh -h
Usage: /home/dreg/gef-extras.sh [-b <main|dev>] [-p <path_to_install>]

By default it uses main and default path logic

Examples of use:

./gef-extras.sh <- (main branch, default path)
./gef-extras.sh -b main <- (main branch, default path)
./gef-extras.sh -b dev <- (dev branch, default path)
./gef-extras.sh -b dev -p /home/kali/gextras <- (dev branch, specific path)
./gef-extras.sh -p /home/kali/gextras <- (main branch, specific path)
./gef-extras.sh -b main -p /home/kali/gextras <- (main branch, specific path)

Against which architecture was this tested ?

"Tested" indicates that the PR works and the unit test (i.e. make test) run passes without issue.

  • x86-32
  • x86-64
  • ARM
  • AARCH64
  • MIPS
  • POWERPC
  • SPARC
  • RISC-V

Checklist

  • My PR was done against the dev branch, not main.
  • My code follows the code style of this project.
  • My change includes a change to the documentation, if required.
  • If my change adds new code, adequate tests have been added.
  • I have read and agree to the CONTRIBUTING document.

scripts/gef-extras.sh Outdated Show resolved Hide resolved
scripts/gef-extras.sh Show resolved Hide resolved
@hugsy hugsy merged commit c530aa5 into hugsy:dev Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants