New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Safe-Linking (GLIBC >= 2.32) and malloc_state struct #878
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR, some things to change though before merging.
Also it's missing CI tests.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. You can reopen it by adding a comment to this issue. |
Ping @zhouzq-thu ? |
@hugsy Changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last change required (remove the entry in .gitignore) and we're good if tests pass
.gitignore
Outdated
@@ -13,3 +13,5 @@ debug.log | |||
.coverage | |||
htmlcov | |||
.benchmarks | |||
|
|||
.DS_Store |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove, this is not specific to GEF (better to add it to your ~/.gitignore_global instead)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
previous_bin_address = arena.bin_at(index-1) | ||
if previous_bin_address == fd: | ||
return 0 | ||
if _type == "tcache": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we want specific cases such as GlibcTcacheChunk & GlibcFastChunk, it is required to modify the private attribute to be public.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice and clean PR
Solve issue #877.