Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Makefile in the root folder #898

Merged
merged 9 commits into from Oct 13, 2022
Merged

Remove the Makefile in the root folder #898

merged 9 commits into from Oct 13, 2022

Conversation

hugsy
Copy link
Owner

@hugsy hugsy commented Oct 8, 2022

Description/Motivation/Screenshots

tests can be fully controlled through pytest only
linting can be fully controlled through pylint only

so there's no reason to keep the makefile in the root folder

also add pytest-cov for pytest

Against which architecture was this tested ?

"Tested" indicates that the PR works and the unit test (i.e. make test) run passes without issue.

  • x86-32
  • x86-64
  • ARM
  • AARCH64
  • MIPS
  • POWERPC
  • SPARC
  • RISC-V

Checklist

  • My PR was done against the dev branch, not main.
  • My code follows the code style of this project.
  • My change includes a change to the documentation, if required.
  • If my change adds new code, adequate tests have been added.
  • I have read and agree to the CONTRIBUTING document.

@hugsy hugsy marked this pull request as ready for review October 9, 2022 20:59
docs/testing.md Outdated Show resolved Hide resolved
@hugsy hugsy merged commit 1fd0f34 into dev Oct 13, 2022
@hugsy hugsy deleted the no_more_makefile branch October 13, 2022 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants