Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable output buffering #917

Merged
merged 1 commit into from Nov 13, 2022
Merged

Conversation

clubby789
Copy link
Contributor

Description/Motivation/Screenshots

Closes #910
Allows disabling Gef's internal buffer, which can improve usage of long-running commands (such as #906).

Against which architecture was this tested ?

"Tested" indicates that the PR works and the unit test (see docs/testing.md) run passes without issue.

  • x86-32
  • x86-64
  • ARM
  • AARCH64
  • MIPS
  • POWERPC
  • SPARC
  • RISC-V

Checklist

  • My PR was done against the dev branch, not main.
  • My code follows the code style of this project.
  • My change includes a change to the documentation, if required.
  • If my change adds new code, adequate tests have been added.
  • I have read and agree to the CONTRIBUTING document.

@Grazfather
Copy link
Collaborator

This looks fine to me. Should probably be documented with the rest of the config.

@clubby789
Copy link
Contributor Author

What's the right place to document config? I had a brief look but only saw the description in GefSetting in GEF itself

@Grazfather
Copy link
Collaborator

Yeah, I guess we don't document each setting, but if we did, it would go here

@hugsy
Copy link
Owner

hugsy commented Nov 11, 2022

What's the right place to document config? I had a brief look but only saw the description in GefSetting in GEF itself

Don't bother creating docs for GefSetting. I already have a branch where I generate them automatically. I'll merge that eventually.

@hugsy
Copy link
Owner

hugsy commented Nov 11, 2022

Took 2sec to squash merge the branch. Settings are now in the docs (see https://hugsy.github.io/gef/settings/context/)

@hugsy hugsy merged commit 75c76fe into hugsy:dev Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow disabling command output buffering
3 participants