Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to specify the host on which the exporter is accepting connections #1

Merged
merged 2 commits into from
Oct 21, 2019

Conversation

mitakas
Copy link
Contributor

@mitakas mitakas commented Oct 20, 2019

Adds the --host <host> option to the co2-exporter command with a default of 127.0.0.1. This will stop the data being exposed to the internet.

If the host isn't specified for server.listen the server will listen to both :: (IPv6) and possibly 0.0.0.0, see https://nodejs.org/api/net.html#net_server_listen_port_host_backlog_callback

@huhamhire
Copy link
Owner

LGTM

@huhamhire huhamhire merged commit 55b76a4 into huhamhire:master Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants