Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion: Add the button to when you hover a video #1

Closed
RasmusKD opened this issue Apr 17, 2022 · 6 comments
Closed

suggestion: Add the button to when you hover a video #1

RasmusKD opened this issue Apr 17, 2022 · 6 comments

Comments

@RasmusKD
Copy link

No hover:
image

Hover:
image

@brunubarbosa
Copy link

I'm wondering if the best approach is not just to add the button after hover, it would solve another problem which is videos that are not rendered at the first rendering don't have the button added, if the trigger to add the button becomes the hover action it would add the button in every video

@huhuang03
Copy link
Owner

huhuang03 commented Apr 19, 2022

  1. The hover show button feature
    After some try, I found is't not very easy. I will try but don't know when it will be done.

  2. Not rendered at the first rendering don't have the button added issue.
    I can't find a 100% way to reproduce. A 100% way to reproduce will help to resolve this.

@huhuang03
Copy link
Owner

Already fixed #2 .
I will publish to chrome store recently.

@RasmusKD
Copy link
Author

RasmusKD commented May 2, 2022

image
this seemed to happen after this was fixed, not sure if related

@huhuang03
Copy link
Owner

Yes, it's related. And I will try to fix..

@huhuang03
Copy link
Owner

Closed as it's seems fixed in latest version. Can reopen if issue still exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants