Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI not finding config files #15

Closed
drl2 opened this issue May 7, 2024 · 4 comments
Closed

GUI not finding config files #15

drl2 opened this issue May 7, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@drl2
Copy link

drl2 commented May 7, 2024

When trying to run an extract through the GUI, it can't find a book.yaml file that's present in the correct location. Windows 11, 0.4.1 release, using config.zip from the _internal directory in the install folder.

Traceback (most recent call last):
File "travdata\filesio.py", line 364, in open_read
File "zipfile.py", line 1563, in open
File "zipfile.py", line 1492, in getinfo
KeyError: "There is no item named 'core_rulebook_2022\\book.yaml' in the archive"

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
File "travdata\gui\extraction\runnerwin.py", line 46, in run
File "travdata\extraction\bookextract.py", line 217, in extract_book
File "travdata\config_init_.py", line 90, in load_group
File "travdata\config_init_.py", line 244, in load_book
File "contextlib.py", line 137, in enter
File "travdata\filesio.py", line 366, in open_read
travdata.filesio.NotFoundError: core_rulebook_2022\book.yaml

Stopped.

image

@huin
Copy link
Owner

huin commented May 7, 2024

Thanks for your report!

I have now reproduced this on my end. My bad, I should have tested the new ZIP file features on Windows before announcing 0.4.0 onwards. I'll try to look into the exact cause and fix this evening (UK time).

Mitigation

In the meantime, you should be able to work around this specific problem by using an unzipped configuration in a folder.

  1. Download https://github.com/huin/travdata/releases/download/v0.4.1/config-v0.4.1.zip
  2. Extract config-v0.4.1.zip into a folder.
  3. In the Travdata GUI use "Select config" -> "Select directory", and then choose the folder that contains config.yaml.

This seems to work for me, where choosing a ZIP file does not.

@huin
Copy link
Owner

huin commented May 7, 2024

Filed #16 to avoid this type of thing in future.

@huin huin added the bug Something isn't working label May 7, 2024
@huin huin self-assigned this May 7, 2024
@huin huin closed this as completed in e4e94b1 May 7, 2024
@huin huin reopened this May 7, 2024
@huin
Copy link
Owner

huin commented May 7, 2024

Reopening until I've created a release containing this fix.

@huin huin closed this as completed May 7, 2024
@huin
Copy link
Owner

huin commented May 7, 2024

Release v0.4.2 should fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants