Skip to content

Commit

Permalink
Revert "Activate race-detection for those modules that are passing it"
Browse files Browse the repository at this point in the history
This reverts commit 845a00b.

Reasons for reversal:
- provided impetus for clearing out races (onflow#1073, onflow#1095)
- network tests now pass with race detector on!
- but those  timings are preposterous
  • Loading branch information
huitseeker committed Aug 18, 2021
1 parent 278b187 commit 2bf3a7c
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,8 @@ install-tools: crypto/relic/build check-go-version

.PHONY: unittest
unittest:
# test some packages with Relic library and data race detection enabled
GO111MODULE=on go test -coverprofile=$(COVER_PROFILE) -covermode=atomic $(if $(JSON_OUTPUT),-json,) -race --tags relic ./access/... ./consensus/... ./model/... ./state/... ./storage/... ./utils/...
# test all packages with Relic library enabled
GO111MODULE=on go test -coverprofile=$(COVER_PROFILE) -covermode=atomic $(if $(JSON_OUTPUT),-json,) --tags relic ./cmd... ./engine/... ./fvm/... ./ledger/... ./module/... ./network/...
GO111MODULE=on go test -coverprofile=$(COVER_PROFILE) -covermode=atomic $(if $(JSON_OUTPUT),-json,) --tags relic ./...
$(MAKE) -C crypto test
$(MAKE) -C integration test

Expand Down

0 comments on commit 2bf3a7c

Please sign in to comment.