Fix pubkey_to_address function: add native ripemd-160 #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
|
Is this going to be merged in? The OpenSSL issue is currently blocking us from integrating Cosmos: aleph-im/aleph-sdk-python#20 |
|
@hukkin I would like to connect with you on how to push this issue forward |
|
Ah, @waddafunk one more thing I noticed while going through the @sipa implementation of the hashing algorithm: It is not constant time, therefore it must be only used for testing purposes (and not by default): |
|
But then again, not being constant time is not that bad, as it is only being used to calculate the address from the public key. |
|
Yes as the comment you mentioned said using it in this context shouldn't be a problem. But I don't know if this will be merged repo has been inactive for a while now 😕 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added python native ripemd-160 algorithm implemented by user @sipa. Fixed pubkey_to_address function that wasn't working anymore. generate_wallets (and probably more) is broken without it
Solution found in this Bitcoin issue.