Fix triggering onStopped and onEnded when restarting a stopped timer #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
onResetTimer
on a stopped timer triggersonStop
andonEnded
events. I expect these event not to trigger if the timer is not running.Consider this use case. I want to create a countdown timer that restarts from the beginning every 5 seconds:
I expect this code to work, but every time in calls
onResetTimer
it also triggersfetchEnded
, so it enters an infinite loop.This fix replaces
isRunning || _startTime > 0
withisRunning && _startTime > 0
, so now resetting a stopped container doesn't trigger these events.