Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base with proxy and save shouldn't be part of classes hierarchy #26

Closed
andreybs11 opened this issue Feb 25, 2016 · 0 comments
Closed

Base with proxy and save shouldn't be part of classes hierarchy #26

andreybs11 opened this issue Feb 25, 2016 · 0 comments
Assignees
Milestone

Comments

@andreybs11
Copy link
Contributor

We are aware of known issues happening because the proxy and save were attached as part of components classes hierarchy (from BaseComponent) instead of using composition

Known issues

  • Landing components can't detect emptiness state
  • Proxy or save can't be added to any level of the components tree, so they were always required at root component of view

Suggested solution:
Create the concept of flows which are managed by handlers. This will let us separate proxy (will be known as 'fetch-flow') and save-flow to be compose into any component class definition

@andreybs11 andreybs11 added the bug label Feb 25, 2016
@andreybs11 andreybs11 self-assigned this Feb 25, 2016
@andreybs11 andreybs11 added this to the v1.1.0 milestone Feb 25, 2016
andreybs11 added a commit that referenced this issue Feb 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants