Issue #38 : Emptiness detection is not correctly resolved for children with several promises

README.md

@@ -67,10 +67,19 @@ Performs a single request to retrieve the resources required by the whole compon
 ### setup
 
 After the resources are loaded, stores a `$view` reference, sets up some resources, caches the tags defined in `this.S`, automatically calls `bindEvents` and performs children set up.
+Implicit flow during `setup`:
+* `this.$view` is set
+* `translateOptions` is called
+* `configureComponent` is called (you should overwrite it and call `appendToView` to initialize view)
+* `_findLocalElems` is called (sets `this.t` with cached tags)
+* `bindEvents` is called (you should overwrite it for event binding)
+* `childrenSetup` is called
+* `READY` event is triggered
+* `setupCompleted` is called
 
 ### setData
 
-If the component includes capabilities to communicate with the server using a proxy (i.e. by composition of FetchHandler) they can retrieve data and load it into the components tree.
+If the component includes capabilities to communicate with the server using a proxy (i.e. they extend from BaseWithProxy) they can retrieve a payload to load data into the component tree.
 
 ## component's api I (data flow)
 

src/blocks/base-ui.js

@@ -365,7 +365,17 @@ define([
                 // Resolved promise callback considers emptiness check result (emptyState)
                 var allChildrenEmptiness = Promise.all(childrenEmptinessPromisesArray),
                     chainAllChildrenEmptiness = allChildrenEmptiness.then(function(results) {
-                        var isLocalEmpty = self.checkLocalEmptiness(results[0]);
+                        // Check all results are true
+                        var isLocalEmpty = results.every(function(value) {
+                            if (typeof value === 'boolean') {
+                                return value === true;
+                            } else if (typeof value === 'object') {
+                                return self.checkLocalEmptiness(value);
+                            } else {
+                                Logger.error('base-ui : unknown child emptiness result', value);
+                                return false;
+                            }
+                        });
                         // Empty if promise results are empty and outter result is empty too
                         return emptyState && isLocalEmpty;
                     });

src/data-flow/save/binder.js

@@ -162,10 +162,12 @@ define([
          */
         _performSaveErrorActions : function(uiErrorCallback, errors) {
             Logger.warn('SaveBehavior: unable to save data', arguments);
-            // NOTICE:
-            // testing if `errors` is an array is a hint to know if it is a set of validation errors
-            if ('function' === typeof uiErrorCallback && $.isArray(errors)) {
-                uiErrorCallback(errors);
+
+            if ('function' === typeof uiErrorCallback) {
+                var wasHandledByUi = uiErrorCallback(errors);
+                if (!wasHandledByUi) {
+                    this.opts.onComponentSaveError(errors);
+                }
             } else {
                 this.opts.onComponentSaveError(errors);
             }