Add extra meter sensors (EG, Eastron meter) #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hultenvp
requested changes
Oct 27, 2023
There was a problem hiding this comment.
Please test with HA. I cannot modify and test myself
EDIT: I'm also reviewing changes from another contributor. Looks like s/he more or less added everything for meter items a,b and c, except the current and voltage. See https://github.com/hultenvp/solis-sensor/pull/332/files
Could you modify your code to cover voltage and current for meter items a/b/c? Then we have a complete set of attributes for all the meter items.
|
Extra fields added, and corrected the fields from inverterDetail API |
|
No errors reported in mass terminal |
hultenvp
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a couple of extra sensors to measure grid under current and voltage - ie the Eastron or similar meter (not EPM).
This is from the Solis spec and I've verified the data is returned in another app (c#).