New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(report): Include tap mocha reporter by default #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I'm wondering if we the test directory should be an optional argument, is there any reason why you defined at the brightscript level?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some dependencies are using the wrong registry
We'll need a version bump since there are breaking changes, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried running a simple test but ran into some issues, comments below
This removes the now-unnecessary `file` subcommand and sets up a default command with no subcommands.
0ac0542
to
7e4b1b7
Compare
Since we haven't hit 1.0 I think there's no expectation of the API being stable (at least according to the semver spec). We're coming up to 1.0 though! I think once we add |
(rebased on top of #8 now that that's landed!) |
Only because I don't think we've configured the top-level |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, 🚢 it
Rather than hand-writing our own reporters, we can pipe
brs
'sstdout
directly throughtap-mocha-reporter
and leverage all of the reporters that it supports. That's more than enough to get us started, and allowsroca
users to write their own TAP reporters as desired!