Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate iFrame markup and iFrame width/height #36

Closed
danhumaan opened this issue May 18, 2016 · 1 comment
Closed

Duplicate iFrame markup and iFrame width/height #36

danhumaan opened this issue May 18, 2016 · 1 comment
Assignees
@danhumaan
Labels
bug enhancement Fixed: Awaiting Release
Milestone
v0.3.0

Comments

@danhumaan
Copy link
Collaborator

There's two minor markup changes that I've discovered need resolving:

  1. There is duplicate iframe markup for .modaal-content which needs to be resolved.
  2. With the new width and height updates in Unable set Modaal width or height #27 being applied to the outer .modaal-container, we should simplify the JS and set the iframe elements width/height to 100% to fill it's parent element. This will also allow it to become responsive by using max-width instead of width on the iframe element itself.
@danhumaan danhumaan added this to the v0.3.0 milestone May 18, 2016
@danhumaan danhumaan self-assigned this May 18, 2016
danhumaan added a commit that referenced this issue May 18, 2016
@danhumaan
Issue #27 and #36 - removed duplicate markup and modified width/heigh…
2114c94 
…t control for iframe content type
@danhumaan danhumaan changed the title Duplicate iFrame markup and iFrame with/height Duplicate iFrame markup and iFrame width/height May 18, 2016
@danhumaan danhumaan mentioned this issue Jun 21, 2016
Merged
@danhumaan
Copy link
Collaborator Author

A fix has been just been rolled out in the latest release for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danhumaan danhumaan

Labels
bug enhancement Fixed: Awaiting Release
Projects
None yet
Milestone
v0.3.0
Development

No branches or pull requests
1 participant
@danhumaan