Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send focus to more semantic element on open #50

Closed
marcysutton opened this issue Jun 1, 2016 · 2 comments
Closed

Send focus to more semantic element on open #50

marcysutton opened this issue Jun 1, 2016 · 2 comments

Comments

@marcysutton
Copy link

marcysutton commented Jun 1, 2016

The modal has focus management but when it opens, nothing is announced in Voiceover. If you send focus instead to the element with role="dialog" and an aria-label, those will be announced when the dialog opens. Or you could send focus to the close button–I've heard of people doing it either way.

Here is a screenshot showing the wrapping dialog and DIV inside with tabindex="0":
Dialog with browser dev tools open onto DOM

You could move tabindex to the dialog element and change its value to -1, that way it won't be in the explicit tab order.

@danhumaan danhumaan added the bug label Jun 3, 2016
@danhumaan danhumaan added this to the v0.3.0 milestone Jun 3, 2016
@danhumaan
Copy link
Collaborator

Hi @marcysutton firstly, thanks for taking the time to review this and raise the issue. I've flagged this ticket as a bug and assigned it to our next milestone so we can get it looked at, and a fix rolled out as soon as possible.

danhumaan added a commit that referenced this issue Jun 10, 2016
@danhumaan
Copy link
Collaborator

Hi @marcysutton, thanks again for your contribution. A fix has been just been rolled out in the latest release for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants