Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Holding down tab causes the tab scope to break from the modal content #2

Closed
dropddesigns opened this issue Apr 20, 2016 · 2 comments
Closed

Holding down tab causes the tab scope to break from the modal content #2

dropddesigns opened this issue Apr 20, 2016 · 2 comments

Comments

@dropddesigns
Copy link

Tabbing through slowly seems to maintain the tab scope to within the modal content and address bar but when I held down tab, it breaks out of the modal content and I can start tabbing through the main web content that should not be in focus.

Browser: Google Chrome 50.0.2661.75 m
@danhumaan
Copy link
Collaborator

Hi @dropddesigns thanks for raising this issue, we'll investigate and work in an appropriate a resolution soon.

cbotman added a commit that referenced this issue Apr 21, 2016
@cbotman
Fix issue #2. Check for when focus escapes modal moved from keyup to …
5c75ab8 
…keydown, which fires repeatedly when tab is help (keyup doesn't).
cbotman added a commit that referenced this issue Apr 21, 2016
@cbotman
Merge pull request #5 from humaan/fix-issue-2
7d62a9c 
Fix issue #2.
@cbotman
Copy link
Contributor

cbotman commented Apr 21, 2016

This is now fixed. :)

@cbotman cbotman closed this as completed Apr 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dropddesigns @cbotman @danhumaan