Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page shift on modal open, two scrollbars on modal close #43

Closed
shchukin opened this issue May 20, 2016 · 3 comments
Closed

Page shift on modal open, two scrollbars on modal close #43

shchukin opened this issue May 20, 2016 · 3 comments

Comments

@shchukin
Copy link

Hello.
Thanks for plugin.

When I open modal window, my page jump in right direction for a half scrollbar width.
It happens because you block page by overflow: hidden; and original scrollbar disappear.
I think here is no choice but to remember scrollbar width and set suitable padding-right.
(check bootstrap modal for example)

When I close the window I see two of scrollbars: http://prntscr.com/b67niq
I think you should release page back to normal only after fade out animation is finished.
(check magnific popup for example)

If you guys work on MAC you probably see no scrollbars at all. There is an option in system settings to turn on scrollbars: http://prntscr.com/b67pgu

@danhumaan danhumaan added the bug label May 20, 2016
@danhumaan
Copy link
Collaborator

Hi @shchukin I've enabled scrollbars to always and can see the flicker of double scrollbars on close as per your screenshot. thanks for raising the ticket, we'll review it in more detail in the near future and try to find an appropriate solution.

@danhumaan danhumaan added this to the v0.3.2 milestone Jul 25, 2016
@danhumaan danhumaan self-assigned this Jul 25, 2016
@danhumaan
Copy link
Collaborator

Hey @shchukin, thanks for your patience and for raising this task many months ago. We've finally found some time to address some outstanding items and tasks and I've made this a priority to fix and address in the next release.

As such i've pushed through some updates which will be released soon. Thanks again.

@shchukin
Copy link
Author

@danhumaan Good luck with this one!

mckelvaney pushed a commit to mckelvaney/Modaal that referenced this issue Mar 10, 2018
@danhumaan danhumaan modified the milestones: v0.3.2, v0.4.0 May 28, 2018
@danhumaan danhumaan mentioned this issue May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants