Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard-coded “(Press escape to close)” in dialog title aria-label (l10n) #92

Closed
mirka opened this issue May 11, 2017 · 2 comments
Closed

Comments

@mirka
Copy link

mirka commented May 11, 2017

There is a “(Press escape to close)” appended to the dialog title aria-label that can't be overridden through the accessible_title or the localization options added in #41.
https://github.com/humaan/Modaal/blob/master/source/js/modaal.js#L358

@danhumaan
Copy link
Collaborator

Thanks @mirka good pickup.

@danhumaan
Copy link
Collaborator

This has been been addressed. The relevant hard coded text has been replaced with the close_aria_label option value so users who wish to overwrite it along with the close button label, can do so.

This will be rolled out in the next milestone release

mckelvaney pushed a commit to mckelvaney/Modaal that referenced this issue Mar 10, 2018
@danhumaan danhumaan modified the milestones: v0.3.2, v0.4.0 May 28, 2018
@danhumaan danhumaan mentioned this issue May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants