Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare core executions #10

Merged
merged 22 commits into from
Jun 24, 2024
Merged

Conversation

Binlogo
Copy link
Contributor

@Binlogo Binlogo commented Jun 5, 2024

Fixes #11

General core logic part is initially ready, include warp library to framework to support dynamic link for more platforms.

More roadmap: #7

@Binlogo Binlogo mentioned this pull request Jun 5, 2024
14 tasks
@Binlogo Binlogo force-pushed the feat/primer-core branch 2 times, most recently from ab8e695 to d0f827e Compare June 9, 2024 14:51
@Binlogo Binlogo force-pushed the feat/primer-core branch 2 times, most recently from adb4ffb to eded5ef Compare June 16, 2024 16:41
@Binlogo Binlogo marked this pull request as ready for review June 16, 2024 17:25
@Binlogo
Copy link
Contributor Author

Binlogo commented Jun 16, 2024

Please review, @akesson. Thank you. If you have any suggestions, please point them out, and I will address them.

src/core.rs Outdated Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
examples/with-tuist/tuist-workspace/README.md Outdated Show resolved Hide resolved
examples/with-tuist/tuist-workspace/README.md Outdated Show resolved Hide resolved
examples/with-tuist/tuist-workspace/README.md Outdated Show resolved Hide resolved
Copy link
Member

@akesson akesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is great. A really nice addition.

The tuist example readme needs improvements. See comments.

I also see that there's a lot of temporary stuff generated (*.xcworspace, .*xcproject, Derived, target etc). Are there any convenient way to remove all temporary cache stuff? Could you add instructions for it in a readme?

In any case: really great stuff!

@akesson
Copy link
Member

akesson commented Jun 23, 2024

Oh, and sorry for not reviewing it before. I have a lot of things on my plate... I'll try to be faster.

@Binlogo Binlogo requested a review from akesson June 23, 2024 14:01
@Binlogo
Copy link
Contributor Author

Binlogo commented Jun 23, 2024

@akesson Thanks for your comments, I've updated them. Please review again. 🙏

@Binlogo Binlogo force-pushed the feat/primer-core branch 6 times, most recently from 921ac2d to d1e8cda Compare June 23, 2024 15:18
Copy link
Member

@akesson akesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still things in the tuist readme that doesn't work, but that's ok. As you pointed out, this is with focus on the core changes.

Just one code comment I did that I'm not sure if you missed, except for that one it's good to go.

src/lib.rs Show resolved Hide resolved
@Binlogo
Copy link
Contributor Author

Binlogo commented Jun 24, 2024

There's still things in the tuist readme that doesn't work, but that's ok. As you pointed out, this is with focus on the core changes.

Yes, I've checked the README, and it worked locally on my machine. However, since this is my first time using Tuist, I might have overlooked some requirements.

This is a starting point to enhance support for more platforms seamlessly. We will continue to fix and improve these aspects, including tests that are not working on CI yet🤦.

Just one code comment I did that I'm not sure if you missed, except for that one it's good to go.

I have responded to that comment. Please review my response to see if I misunderstood anything. If so, I will continue to iterate.

@akesson
Copy link
Member

akesson commented Jun 24, 2024

Sorry for that confusion, regarding the comment without reply, that was in reality already fixed. I was too tired to work yesterday...

A big thank you for this contribution and already looking forwards to the next one 😄

@akesson akesson merged commit 8fac4c4 into human-solutions:main Jun 24, 2024
3 checks passed
@Binlogo Binlogo deleted the feat/primer-core branch June 24, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic linking on iOS, watchOS, and tvOS requires the XCFramework to contain .framework bundles.
2 participants