perf: remove unnecessary module clones (denoland#226)

src/linter.rs

@@ -380,7 +380,7 @@ impl Linter {
     };
 
     for rule in &self.rules {
-      rule.lint_module(context.clone(), module.clone());
+      rule.lint_module(context.clone(), &module);
     }
 
     self.filter_diagnostics(context, &self.rules)

src/rules/ban_ts_comment.rs

@@ -38,7 +38,7 @@ impl LintRule for BanTsComment {
     "ban-ts-comment"
   }
 
-  fn lint_module(&self, context: Context, _module: swc_ecma_ast::Module) {
+  fn lint_module(&self, context: Context, _module: &swc_ecma_ast::Module) {
     context.leading_comments.iter().for_each(|ref_multi| {
       for comment in ref_multi.value() {
         self.lint_comment(&context, comment);

src/rules/ban_ts_ignore.rs

@@ -34,7 +34,7 @@ impl LintRule for BanTsIgnore {
     "ban-ts-ignore"
   }
 
-  fn lint_module(&self, context: Context, _module: swc_ecma_ast::Module) {
+  fn lint_module(&self, context: Context, _module: &swc_ecma_ast::Module) {
     context.leading_comments.iter().for_each(|ref_multi| {
       for comment in ref_multi.value() {
         self.lint_comment(&context, comment);

src/rules/ban_types.rs

@@ -17,9 +17,9 @@ impl LintRule for BanTypes {
     "ban-types"
   }
 
-  fn lint_module(&self, context: Context, module: swc_ecma_ast::Module) {
+  fn lint_module(&self, context: Context, module: &swc_ecma_ast::Module) {
     let mut visitor = BanTypesVisitor::new(context);
-    visitor.visit_module(&module, &module);
+    visitor.visit_module(module, module);
   }
 }
 

src/rules/ban_untagged_ignore.rs

@@ -14,7 +14,7 @@ impl LintRule for BanUntaggedIgnore {
     "ban-untagged-ignore"
   }
 
-  fn lint_module(&self, context: Context, _module: swc_ecma_ast::Module) {
+  fn lint_module(&self, context: Context, _module: &swc_ecma_ast::Module) {
     for ignore_directive in &context.ignore_directives {
       if ignore_directive.codes.is_empty() {
         context.add_diagnostic(

src/rules/ban_untagged_todo.rs

@@ -42,7 +42,7 @@ impl LintRule for BanUntaggedTodo {
     "ban-untagged-todo"
   }
 
-  fn lint_module(&self, context: Context, _module: swc_ecma_ast::Module) {
+  fn lint_module(&self, context: Context, _module: &swc_ecma_ast::Module) {
     context.leading_comments.iter().for_each(|ref_multi| {
       for comment in ref_multi.value() {
         self.lint_comment(&context, comment);

src/rules/constructor_super.rs

@@ -20,9 +20,9 @@ impl LintRule for ConstructorSuper {
     "constructor-super"
   }
 
-  fn lint_module(&self, context: Context, module: swc_ecma_ast::Module) {
+  fn lint_module(&self, context: Context, module: &swc_ecma_ast::Module) {
     let mut visitor = ConstructorSuperVisitor::new(context);
-    visitor.visit_module(&module, &module);
+    visitor.visit_module(module, module);
   }
 }
 

src/rules/default_param_last.rs

@@ -17,9 +17,9 @@ impl LintRule for DefaultParamLast {
     "default-param-last"
   }
 
-  fn lint_module(&self, context: Context, module: swc_ecma_ast::Module) {
+  fn lint_module(&self, context: Context, module: &swc_ecma_ast::Module) {
     let mut visitor = DefaultParamLastVisitor::new(context);
-    visitor.visit_module(&module, &module);
+    visitor.visit_module(module, module);
   }
 }
 

src/rules/eqeqeq.rs

@@ -17,9 +17,9 @@ impl LintRule for Eqeqeq {
     "eqeqeq"
   }
 
-  fn lint_module(&self, context: Context, module: swc_ecma_ast::Module) {
+  fn lint_module(&self, context: Context, module: &swc_ecma_ast::Module) {
     let mut visitor = EqeqeqVisitor::new(context);
-    visitor.visit_module(&module, &module);
+    visitor.visit_module(module, module);
   }
 }
 

src/rules/explicit_function_return_type.rs

@@ -16,9 +16,9 @@ impl LintRule for ExplicitFunctionReturnType {
     "explicit-function-return-type"
   }
 
-  fn lint_module(&self, context: Context, module: swc_ecma_ast::Module) {
+  fn lint_module(&self, context: Context, module: &swc_ecma_ast::Module) {
     let mut visitor = ExplicitFunctionReturnTypeVisitor::new(context);
-    visitor.visit_module(&module, &module);
+    visitor.visit_module(module, module);
   }
 }
 

src/rules/for_direction.rs

@@ -26,9 +26,9 @@ impl LintRule for ForDirection {
     "for-direction"
   }
 
-  fn lint_module(&self, context: Context, module: swc_ecma_ast::Module) {
+  fn lint_module(&self, context: Context, module: &swc_ecma_ast::Module) {
     let mut visitor = ForDirectionVisitor::new(context);
-    visitor.visit_module(&module, &module);
+    visitor.visit_module(module, module);
   }
 }
 

src/rules/getter_return.rs

@@ -26,9 +26,9 @@ impl LintRule for GetterReturn {
     "getter-return"
   }
 
-  fn lint_module(&self, context: Context, module: swc_ecma_ast::Module) {
+  fn lint_module(&self, context: Context, module: &swc_ecma_ast::Module) {
     let mut visitor = GetterReturnVisitor::new(context);
-    visitor.visit_module(&module, &module);
+    visitor.visit_module(module, module);
   }
 }
 

src/rules/mod.rs

@@ -72,7 +72,7 @@ pub trait LintRule {
   fn new() -> Box<Self>
   where
     Self: Sized;
-  fn lint_module(&self, context: Context, module: swc_ecma_ast::Module);
+  fn lint_module(&self, context: Context, module: &swc_ecma_ast::Module);
   fn code(&self) -> &'static str;
 }
 

src/rules/no_array_constructor.rs

@@ -18,9 +18,9 @@ impl LintRule for NoArrayConstructor {
     "no-array-constructor"
   }
 
-  fn lint_module(&self, context: Context, module: swc_ecma_ast::Module) {
+  fn lint_module(&self, context: Context, module: &swc_ecma_ast::Module) {
     let mut visitor = NoArrayConstructorVisitor::new(context);
-    visitor.visit_module(&module, &module);
+    visitor.visit_module(module, module);
   }
 }
 

src/rules/no_async_promise_executor.rs

@@ -18,9 +18,9 @@ impl LintRule for NoAsyncPromiseExecutor {
     "no-async-promise-executor"
   }
 
-  fn lint_module(&self, context: Context, module: swc_ecma_ast::Module) {
+  fn lint_module(&self, context: Context, module: &swc_ecma_ast::Module) {
     let mut visitor = NoAsyncPromiseExecutorVisitor::new(context);
-    visitor.visit_module(&module, &module);
+    visitor.visit_module(module, module);
   }
 }
 

src/rules/no_await_in_loop.rs

@@ -20,9 +20,9 @@ impl LintRule for NoAwaitInLoop {
     "no-await-in-loop"
   }
 
-  fn lint_module(&self, context: Context, module: swc_ecma_ast::Module) {
+  fn lint_module(&self, context: Context, module: &swc_ecma_ast::Module) {
     let mut visitor = NoAwaitInLoopVisitor::new(context);
-    visitor.visit_module(&module, &module);
+    visitor.visit_module(module, module);
   }
 }
 

src/rules/no_case_declarations.rs

@@ -20,9 +20,9 @@ impl LintRule for NoCaseDeclarations {
     "no-case-declarations"
   }
 
-  fn lint_module(&self, context: Context, module: swc_ecma_ast::Module) {
+  fn lint_module(&self, context: Context, module: &swc_ecma_ast::Module) {
     let mut visitor = NoCaseDeclarationsVisitor::new(context);
-    visitor.visit_module(&module, &module);
+    visitor.visit_module(module, module);
   }
 }
 

src/rules/no_class_assign.rs

@@ -22,12 +22,12 @@ impl LintRule for NoClassAssign {
     "no-class-assign"
   }
 
-  fn lint_module(&self, context: Context, module: swc_ecma_ast::Module) {
+  fn lint_module(&self, context: Context, module: &swc_ecma_ast::Module) {
     let mut scope_visitor = ScopeVisitor::new();
-    scope_visitor.visit_module(&module, &module);
+    scope_visitor.visit_module(module, module);
     let scope_manager = scope_visitor.consume();
     let mut visitor = NoClassAssignVisitor::new(context, scope_manager);
-    visitor.visit_module(&module, &module);
+    visitor.visit_module(module, module);
   }
 }
 

src/rules/no_compare_neg_zero.rs

@@ -19,9 +19,9 @@ impl LintRule for NoCompareNegZero {
     "no-compare-neg-zero"
   }
 
-  fn lint_module(&self, context: Context, module: Module) {
+  fn lint_module(&self, context: Context, module: &Module) {
     let mut visitor = NoCompareNegZeroVisitor::new(context);
-    visitor.visit_module(&module, &module);
+    visitor.visit_module(module, module);
   }
 }
 

src/rules/no_cond_assign.rs

@@ -18,9 +18,9 @@ impl LintRule for NoCondAssign {
     "no-cond-assign"
   }
 
-  fn lint_module(&self, context: Context, module: Module) {
+  fn lint_module(&self, context: Context, module: &Module) {
     let mut visitor = NoCondAssignVisitor::new(context);
-    visitor.visit_module(&module, &module);
+    visitor.visit_module(module, module);
   }
 }
 

src/rules/no_const_assign.rs

@@ -26,12 +26,12 @@ impl LintRule for NoConstAssign {
     "no-const-assign"
   }
 
-  fn lint_module(&self, context: Context, module: swc_ecma_ast::Module) {
+  fn lint_module(&self, context: Context, module: &swc_ecma_ast::Module) {
     let mut scope_visitor = ScopeVisitor::new();
-    scope_visitor.visit_module(&module, &module);
+    scope_visitor.visit_module(module, module);
     let scope_manager = scope_visitor.consume();
     let mut visitor = NoConstAssignVisitor::new(context, scope_manager);
-    visitor.visit_module(&module, &module);
+    visitor.visit_module(module, module);
   }
 }
 

src/rules/no_control_regex.rs

@@ -22,12 +22,12 @@ impl LintRule for NoControlRegex {
     "no-control-regex"
   }
 
-  fn lint_module(&self, context: Context, module: swc_ecma_ast::Module) {
+  fn lint_module(&self, context: Context, module: &swc_ecma_ast::Module) {
     let mut scope_visitor = ScopeVisitor::new();
-    scope_visitor.visit_module(&module, &module);
+    scope_visitor.visit_module(module, module);
     let scope_manager = scope_visitor.consume();
     let mut visitor = NoControlRegexVisitor::new(context, scope_manager);
-    visitor.visit_module(&module, &module);
+    visitor.visit_module(module, module);
   }
 }
 

src/rules/no_debugger.rs

@@ -17,9 +17,9 @@ impl LintRule for NoDebugger {
     "no-debugger"
   }
 
-  fn lint_module(&self, context: Context, module: swc_ecma_ast::Module) {
+  fn lint_module(&self, context: Context, module: &swc_ecma_ast::Module) {
     let mut visitor = NoDebuggerVisitor::new(context);
-    visitor.visit_module(&module, &module);
+    visitor.visit_module(module, module);
   }
 }
 struct NoDebuggerVisitor {

src/rules/no_delete_var.rs

@@ -19,9 +19,9 @@ impl LintRule for NoDeleteVar {
     "no-delete-var"
   }
 
-  fn lint_module(&self, context: Context, module: swc_ecma_ast::Module) {
+  fn lint_module(&self, context: Context, module: &swc_ecma_ast::Module) {
     let mut visitor = NoDeleteVarVisitor::new(context);
-    visitor.visit_module(&module, &module);
+    visitor.visit_module(module, module);
   }
 }
 

src/rules/no_dupe_args.rs

@@ -22,9 +22,9 @@ impl LintRule for NoDupeArgs {
     "no-dupe-args"
   }
 
-  fn lint_module(&self, context: Context, module: swc_ecma_ast::Module) {
+  fn lint_module(&self, context: Context, module: &swc_ecma_ast::Module) {
     let mut visitor = NoDupeArgsVisitor::new(context);
-    visitor.visit_module(&module, &module);
+    visitor.visit_module(module, module);
   }
 }
 

src/rules/no_dupe_class_members.rs

@@ -23,9 +23,9 @@ impl LintRule for NoDupeClassMembers {
     "no-dupe-class-members"
   }
 
-  fn lint_module(&self, context: Context, module: swc_ecma_ast::Module) {
+  fn lint_module(&self, context: Context, module: &swc_ecma_ast::Module) {
     let mut visitor = NoDupeClassMembersVisitor::new(context);
-    visitor.visit_module(&module, &module);
+    visitor.visit_module(module, module);
   }
 }
 

src/rules/no_dupe_else_if.rs

@@ -19,9 +19,9 @@ impl LintRule for NoDupeElseIf {
     "no-dupe-else-if"
   }
 
-  fn lint_module(&self, context: Context, module: Module) {
+  fn lint_module(&self, context: Context, module: &Module) {
     let mut visitor = NoDupeElseIfVisitor::new(context);
-    visitor.visit_module(&module, &module);
+    visitor.visit_module(module, module);
   }
 }
 

src/rules/no_dupe_keys.rs

@@ -21,9 +21,9 @@ impl LintRule for NoDupeKeys {
     "no-dupe-keys"
   }
 
-  fn lint_module(&self, context: Context, module: Module) {
+  fn lint_module(&self, context: Context, module: &Module) {
     let mut visitor = NoDupeKeysVisitor::new(context);
-    visitor.visit_module(&module, &module);
+    visitor.visit_module(module, module);
   }
 }
 

src/rules/no_duplicate_case.rs

@@ -18,9 +18,9 @@ impl LintRule for NoDuplicateCase {
     "no-duplicate-case"
   }
 
-  fn lint_module(&self, context: Context, module: swc_ecma_ast::Module) {
+  fn lint_module(&self, context: Context, module: &swc_ecma_ast::Module) {
     let mut visitor = NoDuplicateCaseVisitor::new(context);
-    visitor.visit_module(&module, &module);
+    visitor.visit_module(module, module);
   }
 }
 

src/rules/no_empty.rs

@@ -17,9 +17,9 @@ impl LintRule for NoEmpty {
     "no-empty"
   }
 
-  fn lint_module(&self, context: Context, module: Module) {
+  fn lint_module(&self, context: Context, module: &Module) {
     let mut visitor = NoEmptyVisitor::new(context);
-    visitor.visit_module(&module, &module);
+    visitor.visit_module(module, module);
   }
 }
 

src/rules/no_empty_character_class.rs

@@ -17,9 +17,9 @@ impl LintRule for NoEmptyCharacterClass {
     "no-empty-character-class"
   }
 
-  fn lint_module(&self, context: Context, module: swc_ecma_ast::Module) {
+  fn lint_module(&self, context: Context, module: &swc_ecma_ast::Module) {
     let mut visitor = NoEmptyCharacterClassVisitor::new(context);
-    visitor.visit_module(&module, &module);
+    visitor.visit_module(module, module);
   }
 }
 

src/rules/no_empty_interface.rs

@@ -17,9 +17,9 @@ impl LintRule for NoEmptyInterface {
     "no-empty-interface"
   }
 
-  fn lint_module(&self, context: Context, module: swc_ecma_ast::Module) {
+  fn lint_module(&self, context: Context, module: &swc_ecma_ast::Module) {
     let mut visitor = NoEmptyInterfaceVisitor::new(context);
-    visitor.visit_module(&module, &module);
+    visitor.visit_module(module, module);
   }
 }
 

src/rules/no_empty_pattern.rs

@@ -17,9 +17,9 @@ impl LintRule for NoEmptyPattern {
     "no-empty-pattern"
   }
 
-  fn lint_module(&self, context: Context, module: swc_ecma_ast::Module) {
+  fn lint_module(&self, context: Context, module: &swc_ecma_ast::Module) {
     let mut visitor = NoEmptyPatternVisitor::new(context);
-    visitor.visit_module(&module, &module);
+    visitor.visit_module(module, module);
   }
 }