Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move node representation onto state #41

Open
esjewett opened this issue Dec 2, 2016 · 3 comments
Open

Move node representation onto state #41

esjewett opened this issue Dec 2, 2016 · 3 comments
Assignees

Comments

@esjewett
Copy link
Member

esjewett commented Dec 2, 2016

No description provided.

@esjewett
Copy link
Member Author

esjewett commented Dec 5, 2016

Per Eetu, we store the following on the client-side (in the state):

  • ids of nodes visible in construct (the "construct set")
  • position of nodes in construct

@jiemakel
Copy link
Contributor

jiemakel commented Dec 7, 2016

We could (and for demo purposes should) also support storing the client side state on the server. This would be loaded in at startup, and serialized back specifically based on user action ("Save/Share project/canvas/set"). This isn't a priority, however.

@esjewett
Copy link
Member Author

esjewett commented Dec 7, 2016

Yup, agreed. Once something is on the state, then it's very straightforward to serialize and we don't have to go looking for all the little pieces we want to save. Currently it's just JSON but I'm going to switch it over to immutable.js relatively soon. Both can be serialized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants