Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old code #92

Merged
merged 4 commits into from
Oct 22, 2013
Merged

Remove old code #92

merged 4 commits into from
Oct 22, 2013

Conversation

mattheu
Copy link
Member

@mattheu mattheu commented Sep 29, 2013

I believe this is old code that is no longer used. Its pretty confusing that its still here. I think we should remove it.

@joehoyle Do you know of any reason not to do this?

review #merge

@ghost ghost assigned joehoyle Sep 30, 2013
@joehoyle
Copy link
Member

It's there to support meta boxes on in the edit post screen. Hence you call cmb_do_meta_boxes on the edit term page etc. However, it's a bit of a hack so happy to remove if you think it should be - we can approach the meta boxes anywhere as a new epic perhaps?

@mattheu
Copy link
Member Author

mattheu commented Oct 22, 2013

ah right I see. I couldn't work out where this was used. I guess I don't want to break any compatability. Perhaps this could be moved to a new file and documented a little as a temporary measure? Just so I don't decide it can be deleted again!

👍 Meta boxes anywhere should definitely be the next big thing.

@joehoyle
Copy link
Member

Yeah new file makes sense, with some comment to describe what it's doing.

@ghost ghost assigned mattheu Oct 22, 2013
@mattheu
Copy link
Member Author

mattheu commented Oct 22, 2013

Updated

@joehoyle
Copy link
Member

@mattheu doesn't merge cleanly

@ghost ghost assigned joehoyle Oct 22, 2013
@mattheu
Copy link
Member Author

mattheu commented Oct 22, 2013

updated again!

joehoyle added a commit that referenced this pull request Oct 22, 2013
@joehoyle joehoyle merged commit 6166100 into master Oct 22, 2013
@joehoyle joehoyle deleted the remove-old-code branch October 22, 2013 12:48
@mattheu mattheu mentioned this pull request Nov 21, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants