Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sample IAM policy #265

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

epicfaace
Copy link

This is so that users who don't use WP CLI can still create an IAM policy with the appropriate permissions.

Copy link

@hm-linter hm-linter bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting failed (1058 errors, 83 warnings).

1141 notices occurred in your codebase, but none on files/lines included in this PR.

README.md Show resolved Hide resolved
Co-Authored-By: epicfaace <aramaswamis@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #265 into master will decrease coverage by 37.2%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #265       +/-   ##
============================================
- Coverage     46.43%   9.23%   -37.21%     
  Complexity      260     260               
============================================
  Files             7       7               
  Lines           715     715               
============================================
- Hits            332      66      -266     
- Misses          383     649      +266
Impacted Files Coverage Δ Complexity Δ
inc/class-s3-uploads-stream-wrapper.php 2.17% <0%> (-55.44%) 149% <0%> (ø)
inc/class-s3-uploads.php 23.72% <0%> (-51.7%) 44% <0%> (ø)
inc/class-s3-uploads-image-editor-imagick.php 60% <0%> (-2.86%) 9% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bc1691...32ac188. Read the comment docs.

@joehoyle
Copy link
Member

Thanks @epicfaace , apologies for not getting to this ever. We've since updated the policy (see https://github.com/humanmade/S3-Uploads/blob/master/inc/class-wp-cli-command.php#L72-L103) so this would need updating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants