Catch S3 Delete Error #471
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hm-linter[bot]](https://avatars.githubusercontent.com/in/5455?s=60&v=4){kind=small}
joehoyle
requested changes
Dec 1, 2020
| 'Key' => $partsFrom['Key'] | ||
| ] + $options); | ||
| } catch (Exception $e) { | ||
|
|
There was a problem hiding this comment.
Could you add a call to $this->triggerError here with the exception message? That seems like the best way to surface this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context We have a requirement to restrict the S3 bucket and prevent delete operations to ensure any malicious or accidental changes don't impact the production website.
Problem When GravityForms uploads PDF attachments it puts them in a tmp folder and then moves them to the final location. This coupled with the delete restriction causes an error which stops GravityForms form correctly linking the location of the uploaded PDF.
The solution is quite simple, just a try catch around the delete operation. However, I'm not sure how to raise a warning so any help with completing this would be greatly appreciated.