This repository has been archived by the owner on Oct 13, 2020. It is now read-only.
Fixes: #126, #119, #25, #72 #127
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @pryley, thanks for the PR - we'd typically have PR for each bug fixed, so we can roll back etc if anything goes wrong. I'm happy to write tests for each Pull Request then if you are not familiar with doing that. Looks like you are also using the PHP array shorthand |
| } | ||
|
|
||
| add_filter( 'wp_image_editors', 'wpthumb_add_image_editors' ); | ||
|
|
||
| function wpthumb_create_args_from_size( $args = '' ) | ||
| { |
There was a problem hiding this comment.
Per the WordPress PHP Coding Guidelines, { should never be on their own line.
|
Sure, I'll separate each fix with its own pull request and remove shorthand arrays. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following:
You no longer have to set Native WP sizes to 0x0 to prevent them being NATIVELY generated.