-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft implementation of terms import for term-parent slug and term meta #76
Open
dregula
wants to merge
17
commits into
humanmade:master
Choose a base branch
from
dregula:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an parent Ids Implements hierarchical import of terms and term-meta.
capuderg
added a commit
to awesomemotive/one-click-demo-import
that referenced
this pull request
Dec 1, 2016
Updated content import composer package. This should resolve the #61 issue. Most of the code was from the PR on the original WP importer 2.0: humanmade/WordPress-Importer#76
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just discovered this version 2 of the WordPress Importer, it is a great improvement over v1!
My site (4.5.3) makes extensive usage of hierarchical terms and of term-meta.
It seems that the v4.5 (maybe earlier) export.php will exports a parent slug, rather than an integer ID.
I took the liberty of drafting some code to implement term parentage and term meta.
The attached diff seems to correctly remap an export with a slug for a term parent.
(I always got a slug with my term exports, never an integer. This diff handles everything in the parent element as a string, e.g wp:category_parentSTRING/wp:category_parent )
This diff also will upload term-meta, including multiple wp:termmeta/ elements within the same term.
This diff has been tested only for category, not tags or other taxonomies.
(warning: I haven't submitted a request for any project in many years! ;-)
Thank you! -Don
class-wxr-importer.diff.txt