Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix < php 8.0 #859

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix < php 8.0 #859

wants to merge 2 commits into from

Conversation

joehoyle
Copy link
Member

@joehoyle joehoyle commented Mar 1, 2024

Union return type was only added in 8.0. So this fails the hm-linter checks

Union return type was only added in 7.4.
@joehoyle joehoyle requested a review from kovshenin March 1, 2024 09:46
@joehoyle
Copy link
Member Author

ping @kovshenin to get the project green

@mikelittle
Copy link
Contributor

Is this necessary? Altis master doesn't support PHP < 8.0
Is the fix to configure the automatic lint to check against PHP >= 8.0

@joehoyle
Copy link
Member Author

joehoyle commented Apr 5, 2024

Is the fix to configure the automatic lint to check against PHP >= 8.0

Ideally yes, though HM Linter is blocked on humanmade/linter-bot#162

If we dont want to merge this, I'd suggest we move away from HM Linter and run PHPCS in github actions instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants