Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes CodeCeption tests #838

Closed
wants to merge 2 commits into from
Closed

Conversation

wisyhambolu
Copy link
Contributor

@wisyhambolu wisyhambolu commented Jun 13, 2024

###TESTS ON LOCAL

Acceptance Tests (2) ---------------------------------------
✔ SignupsCest: Test I want to manage my network signups. (14.03s)
✔ SiteCest: Test I want to manage my network sites. (43.03s)
------------------------------------------------------------


Time: 01:25.397, Memory: 22.00 MB

OK (2 tests, 3 assertions)
Flushing the cache...
Removing test databases..

What's next?
  Try Docker Debug for seamless, persistent debugging tools in any container or image → docker debug test-root-db
  Learn more at https://docs.docker.com/go/debug-cli/
Removing headless browser container..

Copy link
Contributor

@mikelittle mikelittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done for finding this.
Is there a possibility to reduce/remove the rate limit on nginx? Otherwise, I think this means all future tests (including ones clients write) will have to incorporate these delays.
Alternatively, do the delays need to be so long?
Tests that take too long to run tend not to get used.

@kovshenin
Copy link
Contributor

Change looks fine. I agree re. long tests though, I think it's worth removing rate limiting in Local Server, it is not useful at all.

@joehoyle
Copy link
Member

We can override the rate limits in the nginx container per https://github.com/humanmade/docker-wordpress-nginx/blob/master/docker-entrypoint.d/config-replacements.sh, we'd need to just define the env vars in https://github.com/humanmade/altis-local-server/blob/master/inc/composer/class-docker-compose-generator.php#L337

@wisyhambolu
Copy link
Contributor Author

Thanks for the feedback everyone, I'll create a PR to override the rate limits in the nginx container.

@wisyhambolu
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants