Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hard-coded installation path for hm-gtm #841

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Remove hard-coded installation path for hm-gtm #841

merged 1 commit into from
Oct 18, 2023

Conversation

mikelittle
Copy link
Contributor

@mikelittle mikelittle commented Oct 17, 2023 •
edited
Loading

This removes the hard-coded installation path for the humanmade/hm-gtm package. If on v17 you manually install hm-gtm without altis/analytics, it should end up in content/plugins not in vendor.
Fixes humanmade/altis-documentation#552

@mikelittle mikelittle mentioned this pull request Oct 17, 2023
Closed
18 tasks
@mikelittle mikelittle merged commit 3a2738f into master Oct 18, 2023
2 of 3 checks passed
@mikelittle mikelittle deleted the 552-remove-hm-gtm-locatoion-override branch October 18, 2023 14:26
@hm-backport hm-backport bot mentioned this pull request Oct 18, 2023
Merged
@roborourke
Copy link
Contributor

Don't forget the backport PRs folks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wisyhambolu wisyhambolu wisyhambolu approved these changes

@kovshenin kovshenin Awaiting requested review from kovshenin

@jerico jerico Awaiting requested review from jerico

Assignees
No one assigned
Labels
backport v17-branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update v17 documentation to note removal of GTM
3 participants
@mikelittle @roborourke @wisyhambolu