Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure clickable traces by default #16

Closed
rmccue opened this issue Jun 5, 2019 · 5 comments
Closed

Configure clickable traces by default #16

rmccue opened this issue Jun 5, 2019 · 5 comments
Assignees

Comments

@rmccue
Copy link
Member

rmccue commented Jun 5, 2019

https://querymonitor.com/blog/2019/02/clickable-stack-traces-and-function-names-in-query-monitor/

We have enough integration to be able to enable this by default.

@rmccue
Copy link
Member Author

rmccue commented Jun 6, 2019

VirtualBox provides a way to pass properties to the VM, so if Chassis can set this, that'll work. I'll file an issue with Chassis upstream.

@rmccue
Copy link
Member Author

rmccue commented Jun 6, 2019

Filed at Chassis/Chassis#638

@rmccue rmccue added this to the 2.0 Beta milestone Jun 12, 2019
@joehoyle
Copy link
Member

joehoyle commented Jul 5, 2019

We can also pass this as an ENV var in local-server, which can probably match whatever constant you want to use here. I'm assuming you're going to PR dev-tools to add the filter to QM too?

@joehoyle
Copy link
Member

Going to punt to post v2

@rmccue
Copy link
Member Author

rmccue commented Oct 15, 2019

#25 for the editor piece and humanmade/altis-local-chassis#39 and humanmade/altis-local-server#56 for the paths, we have an MVP done.

We have a couple extra steps that I'd like to complete, but will file those separately; this issue is now done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants