Add event listener for XB's. #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roborourke
requested changes
Oct 31, 2022
There was a problem hiding this comment.
The JS code is good but this will load the script on every page regardless of whether GaussHolder and native analytics are enabled.
I think it's good to avoid an extra HTTP request too for a small amount of code, a good option would be to use the wp_add_inline_script(), and use the registered script name of either the experiments JS or the GuassHolder JS. You can also check against the Altis config for whether or not the code needs to be run.
This was referenced Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue - https://github.com/humanmade/product-dev/issues/1246
This PR adds an event listener for when Altis Experiences Blocks are changed.