SameSite Cookie Policy #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Travis build failing is a known issue #7 |
goldenapples
approved these changes
Mar 31, 2021
There was a problem hiding this comment.
Looks good, and today I learned about the new array value argument in setcookie.
I'd suggest targeting this PR upstream, but it looks like they're still supporting older versions of PHP. It might be nice as a courtesy to at least open an issue in the upstream repository to let them know about the issue though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5 by setting SameSite policy to None with secured cookie.
Note: PR must be changed to master before merging.