Merge pull request #112 from humanmade/92-tests-directory

Add `NamespaceDirectoryName Exclusion` for `/tests` directories

HM/Sniffs/Files/NamespaceDirectoryNameSniff.php

@@ -45,7 +45,7 @@ public function process( File $phpcsFile, $stackPtr ) {
 		$filename = basename( $full );
 		$directory = dirname( $full );
 
-		// Normalize the directory seperator accross operating systems
+		// Normalize the directory separator across operating systems
 		if ( DIRECTORY_SEPARATOR !== '/' ) {
 			$directory = str_replace( DIRECTORY_SEPARATOR, '/', $directory );
 		}
@@ -55,13 +55,16 @@ public function process( File $phpcsFile, $stackPtr ) {
 			return;
 		}
 
-		if ( ! preg_match( '#/inc(?:/|$)#', $directory, $matches, PREG_OFFSET_CAPTURE ) ) {
+		if (
+			! preg_match( '#/inc(?:/|$)#', $directory, $matches, PREG_OFFSET_CAPTURE )
+			&& ! preg_match( '#/tests(?:/|$)#', $directory, $test_matches, PREG_OFFSET_CAPTURE )
+		) {
 			$error = 'Namespaced classes and functions should live inside an inc directory.';
 			$phpcsFile->addError( $error, $stackPtr, 'NoIncDirectory' );
 			return;
 		}
 
-		$inc_position = $matches[0][1];
+		$inc_position = $matches[0][1] ?? $test_matches[0][1];
 		$after_inc = substr( $directory, $inc_position + strlen( '/inc' ) );
 		if ( empty( $after_inc ) ) {
 			// Base inc directory, skip checks.

HM/Tests/Files/NamespaceDirectoryNameUnitTest/inc/coffee/pass.php

@@ -0,0 +1,3 @@
+<?php
+
+namespace HM\Coding\Standards\Coffee;

HM/Tests/Files/NamespaceDirectoryNameUnitTest/inc/standards/coffee/pass.php

@@ -0,0 +1,3 @@
+<?php
+
+namespace HM\Coding\Standards\Coffee;

tests/fixtures/fail/not-namespace.php.json

@@ -1,7 +1,7 @@
 {
 	"6": [
 		{
-			"source": "HM.Files.NamespaceDirectoryName.NoIncDirectory",
+			"source": "HM.Files.NamespaceDirectoryName.NameMismatch",
 			"type": "error"
 		}
 	],
@@ -11,4 +11,4 @@
 			"type": "error"
 		}
 	]
-}
+}