Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore inc namespace rule in test directories #92

Closed
mikeselander opened this issue Sep 14, 2018 · 2 comments
Closed

Ignore inc namespace rule in test directories #92

mikeselander opened this issue Sep 14, 2018 · 2 comments
Assignees
@mikeselander

Comments

@mikeselander
Copy link
Contributor

The NamespaceDirectoryNameSniff sniff currently requires namespaces within test directory files, but this should not be required as test files are outside of a plugin-based organizational structure.

Should check for /.test and /test directories in path and if found, bypass this rule.
@rmccue
Copy link
Member

rmccue commented Sep 14, 2018

Let’s pick one of these rather than both. I think the handbook has tests/?

@mikeselander
Copy link
Contributor Author

/tests it is 👍 We'll need to adapt hm-base as well, but I'm happy to handle that.

@mikeselander mikeselander mentioned this issue Oct 31, 2018
Merged
3 tasks
@mikeselander mikeselander self-assigned this Dec 17, 2018
@mikeselander mikeselander mentioned this issue Dec 17, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikeselander mikeselander

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rmccue @mikeselander