-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update @humanmade/stylelint-config
in preparation for v2 release
#248
Conversation
Looking a bit closer... this doesn't necessarily solve my problem either. It looks like the bugfix I'm after was released in v13.30, so if HM Linter Bot is using the version of stylelint from here... its still not new enough. Either way, I wonder why we're not committing the lockfile. We do for eslint. |
@mattheu There's no reason not to include the lockfile that I can see. If you can PR the update / version pin, I can get that pushed out as a patch release |
@mattheu We include the package lockfile in ESLint because I deployed with NPM, and since Ryan used Yarn, only Yarn was ignored :) |
Updated this PR to also update the the stylelint and WP stylelint rules to latest versions. |
stylelint-config-wordpress
to @wordpress/stylelint-config
For the most part this is working as expected testing locally, as @tfrommen highlights here in Slack that this will need to be shipped as a major SemVer release in HM CS v2.0. Whilst testing this locally works fine for me, hmlinter linter-bot continues to fail, I need to look closer at either the linter-bot stylelint integration in humanmade/linter-bot#144 or in stylelint itself to resolve the underlying issue. I've published the updated config here in pull request as it currently stands as stylelint:
enabled: true
version: next |
Oh now that is a neat idea. Although running this I get the following error:
|
This was fixed with this commit @mattheu That was fixed in |
stylelint-config-wordpress
to @wordpress/stylelint-config
@humanmade/stylelint-config
v2
@humanmade/stylelint-config
v2@humanmade/stylelint-config
in preparation for v2 release
I've got a few more things to do, will follow this up in further PRs For now, this can be merged and I'll push up a new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we treat master
as home for the upcoming v2 releases, this looks alright to me. 👍
I am having some issues with HM Linter bot flagging style issues, but I'm not getting the same errors locally. and I'm a little stumped by it. I don't know for sure, but i think committing the package lock file could help ensure this isn't caused by mismatched versions.
The actual problem is this: https://github.com/humanmade/HM-Playbook/pull/200, and the errors flagged are related to the rule
function-calc-no-invalid
. Yet its not happening locally. Looks like this was a bug in stylelint when used with sass files, and it was fixed a year ago. This makes me suspect that this could be caused by a version mismatch, and therefore may be fixed by committing the lockfile.