Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PHPCS to v3.4 #88

Merged
merged 5 commits into from
Feb 18, 2019
Merged

Update PHPCS to v3.4 #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c093a39
Update PHPCS vrsion to 3.3
mikeselander Sep 6, 2018
0e61841
Declare PHP gte 7.1 as a requirement
mikeselander Dec 18, 2018
696fa5d
Platform arg is unnecessary, removing
mikeselander Dec 18, 2018
0d34dab
Update PHPCS to v3.4
mikeselander Jan 11, 2019
1224fcd
Keep tabWidth set throughout entire test suite
mikeselander Feb 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,10 @@
"type": "project",
"license": "GPL-2.0-or-later",
"require": {
"php": ">=7.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this will be an issue, but just to note I've seen some peeps using php7.0 for travis/circle setups, so we should expect our next version to stop working in those situations.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could set that back to 7.0 if that is a wide-spread practice. I'm a little concerned about our engineers testing in WP 7.0 when all of our major hosting partners are using 7.2+. I know of only one project where we don't have access to 7.0+ and they don't appear to be using the standards.

"wp-coding-standards/wpcs": "^0.14.0",
"fig-r/psr2r-sniffer": "^0.5.0",
"squizlabs/php_codesniffer": "~3.2.0"
"squizlabs/php_codesniffer": "~3.4.0"
},
"require-dev": {
"phpunit/phpunit": "^5.7"
Expand Down
4 changes: 4 additions & 0 deletions tests/FixtureTests.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,10 @@ public function setUp() {
$this->config->cache = false;
$this->config->standards = [ 'HM' ];

// Keeping the tabWidth set inline with WPCS.
// See: https://github.com/humanmade/coding-standards/pull/88#issuecomment-464076803
$this->config->tabWidth = 4;

$this->ruleset = new Ruleset( $this->config );
}

Expand Down