New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update clean-webpack-plugin and include as default for production builds. #31
Comments
Such an idiot - didn't see this was bundled. However - the version bundled is Additionally... any reason not to just clean the webpack output path by default for production builds? |
No strong opinions on cleaning by default, I think if I consider your argument for long enough you'll have me convinced. We should definitely update the dependency, nice catch. |
We cannot actually clean by default, because then if somebody does module.exports = [
presets.production( { ... } ),
presets.production( { ... } ),
]; then only one build will get output correctly (whichever runs second will clear the build folder, removing all files from the first-run build). However, this can be added as an option, for sure. |
It would be nice to include
clean-webpack-plugin
for production builds to ensure the build directory doesn't contain any old files.Let me know your thoughts - happy to open a PR for this.
The text was updated successfully, but these errors were encountered: