Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robonode crypto integration #31

Merged
merged 11 commits into from
Jun 28, 2021
Merged

Robonode crypto integration #31

merged 11 commits into from
Jun 28, 2021

Conversation

MOZGIII
Copy link
Contributor

@MOZGIII MOZGIII commented Jun 25, 2021

This PR integrates auth ticket signing at robonode server and verification at the humanode peer.

To do:

  • update crypto traits at robonode-server
  • update crypto traits at pallet-bioauth
  • integrate robonode-crypto into robonode-server
  • store the key at genesis ratrher than at constant at pallet-bioauth
  • integrate a simple temporary mock for validator-key-verification at robonode-server
  • integrate a simple temporary mock for validator-key-signing at bioauth-flow this part of bioauth-flow is not integrated yet

Remarks

  1. The wrapper type used instead of the real robonode_crypto::PublicKey at the humanode-runtime ended up rather odd, we might want to implement it differently.
  2. To properly complete the validator key checking, we need to first finish with the consensus implementation (aura). This PR can be merged before that, and we'll create another one to address the consensus/bioauth integration.

@MOZGIII MOZGIII force-pushed the proper-crypto branch 7 times, most recently from c55376d to a1a16eb Compare June 26, 2021 19:24
@MOZGIII MOZGIII marked this pull request as ready for review June 26, 2021 19:26
@MOZGIII MOZGIII force-pushed the proper-crypto branch 4 times, most recently from 33ef05c to 0d153d5 Compare June 28, 2021 16:40
@MOZGIII MOZGIII merged commit ed72205 into master Jun 28, 2021
@MOZGIII MOZGIII deleted the proper-crypto branch June 28, 2021 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants