Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for installing glslang #6

Closed
jamestmartin opened this issue Aug 29, 2021 · 3 comments
Closed

Support for installing glslang #6

jamestmartin opened this issue Aug 29, 2021 · 3 comments

Comments

@jamestmartin
Copy link

I use the GLSL-to-SPIR-V compiler glslangValidator from KhronosGroup/glslang as part of my build process. I would greatly appreciate it if you'd consider adding an option to install it with this action.

@styler00dollar
Copy link

Any update?

@humbletim
Copy link
Owner

As of v1.2.0-beta this action now supports building and installing glslangValidator as well:

 -name: Prepare Vulkan SDK
   uses: humbletim/setup-vulkan-sdk@v1.2.0-beta
   with:
     vulkan-query-version: 1.3.204.0
     vulkan-components: Vulkan-Headers, Vulkan-Loader, Glslang
     vulkan-use-cache: true

This action is mainly meant for compiling Vulkan SDK components from corresponding source code and with caching enabled it seems reasonable enough to include glslangValidator that way.

However, for projects that depend on multiple binary tools from the full Vulkan SDK, it may make more sense to just perform unattended installation of the official Vulkan SDK prebuilt release. In case useful to others I've put together a new action which automates that whole process for linux/mac/windows here: actions/install-vulkan-sdk.

@humbletim
Copy link
Owner

v1.2.0 action released with glslang support; thanks for the feedback. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants