Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if function humbug_phpscoper_expose_class exists #811

Merged
merged 4 commits into from
Jan 5, 2023

Conversation

leoloso
Copy link
Contributor

@leoloso leoloso commented Dec 30, 2022

Fixes #809

@theofidry I can't run the tests locally, as composer update is failing (am I doing something wrong?):

  Problem 1
    - humbug/box[4.0.0, ..., 4.2.0] require composer-plugin-api ^2.2 -> found composer-plugin-api[2.1.0] but it does not match the constraint.
    - Root composer.json requires humbug/box ^4.0 -> satisfiable by humbug/box[4.0.0, ..., 4.2.0].

But I can see the tests are passing here on GitHub

@theofidry
Copy link
Member

I can't run the tests locally, as composer update is failing (am I doing something wrong?)

If you do make phpunit it should work. The issue is that you need to source .composer-root-version since there is a circular dependency (in dev) with Box.

Copy link
Member

@theofidry theofidry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 The patch looks good to me thanks!

I would like to capture this into a dedicated test for the future so I'll hold off a bit for the merge. Hopefully I should be able to figure it out soon :)

@theofidry theofidry enabled auto-merge (squash) January 5, 2023 23:44
@theofidry theofidry merged commit f7750a6 into humbug:main Jan 5, 2023
@theofidry
Copy link
Member

Thanks a lot @leoloso!

@leoloso
Copy link
Contributor Author

leoloso commented Jan 6, 2023

Thanks to you @theofidry 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fatal error: Cannot redeclare humbug_phpscoper_expose_class()
2 participants