Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .gitattributes #899

Merged
merged 1 commit into from
Nov 5, 2023
Merged

Update .gitattributes #899

merged 1 commit into from
Nov 5, 2023

Conversation

szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Nov 5, 2023

Remove non-existent files, add new development files.

Test command: git archive HEAD | tar -t --exclude='*/*'

One more to add: composer.lock - the lock file is not used in packages.

Comment on lines -20 to +23
/phpstan.neo.dist export-ignore
/phpstan.neon.dist export-ignore
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A typo

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to contribute.

@theofidry theofidry merged commit bc9460d into humbug:main Nov 5, 2023
118 checks passed
@szepeviktor szepeviktor deleted the patch-3 branch November 5, 2023 10:40
@theofidry
Copy link
Member

Thank you @szepeviktor

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Nov 5, 2023

Actually fixing all these is a solution for today.
The Integrity workflow keeps all these fixed at every commit.
https://github.com/szepeviktor/byte-level-care/blob/master/.github/workflows/reusable-integrity.yml#L39
... maybe this is only valid in my golden cage

@theofidry
Copy link
Member

theofidry commented Nov 5, 2023

I can see a few being helpful, not sure but a few others, but maybe I'll try adding those in the future, thanks for the ref :)

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Nov 5, 2023

For example the one that looks for ignored files in the index.

$ git ls-files --cached --ignored --exclude-standard
bin/infection.sh
bin/php-scoper
build/.gitkeep
fixtures/set028-symfony/expected-output
fixtures/set030/expected-output

Investigating ... 🕵🏻‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants