Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: feat: Handle ambiguous functions #981

Closed
wants to merge 12 commits into from

Conversation

theofidry
Copy link
Member

@theofidry theofidry commented Apr 12, 2024

Closes #960.

  • Docs
  • e2e tests
  • unit tests
  • Review the terminology
  • double check TODOs

theofidry added a commit that referenced this pull request Apr 14, 2024
…985)

At the time the specs were written, there were much less configuration settings and I wanted a clear view of the default settings, not having them declared in an less obvious place (e.g. the spec test case).

Now with the advent of readonly classes, promoted properties and named parameters, I think it is time to reconsider this. This will also make it easier to introduce new settings like needed for #981.
theofidry added a commit that referenced this pull request Apr 14, 2024
…ymbols (#1007)

Previously if a non-fully qualified symbol was matching an exposed or excluded one, PHP-Scoper assumed it matched. Technically this is wrong, but the assumption was still good for 99% of the cases.

However with #981, we no longer need this.
@theofidry theofidry closed this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting expose-global-functions to false breaks internal function calls
1 participant