feat: import @hargonix hardware diff #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry to hear that rebasing is so hard. Have you tried to just merge the
changes from master? Or is it the amount of changes?
What do you suggest to do?
|
|
It's mostly the amount of changes, I think it is doable with enough attention to detail, I'm going to try again later. |
hargoniX
force-pushed
the
rustl4rehumenda
branch
from
37d7f08
to
9c1730f
Compare
|
This is properly rebased now but it doesn't build yet and also contains all of my thesis. I'm gonna look into fixing the build. Do you want |
hargoniX
force-pushed
the
rustl4rehumenda
branch
10 times, most recently
from
cfdb29a
to
a048e73
Compare
hargoniX
force-pushed
the
rustl4rehumenda
branch
from
a048e73
to
710e9ed
Compare
|
With the additional fix commit everything is compiling now. I'll check if it still does the correct thing on irl hardware on Wednesday. |
|
Tested, everything is still working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This imports most of my hardware API related diff in the repo. I did not succeed in properly rebasing my branch onto humenda/master after trying for half a day sadly. This patch alone is not quite capable of building as some things that I can't seem to figure out are still failing but I'll leave it here for now regardless.