CanCreatePublicContent not checked

[luke-]

Reproduce:

• Allow Space members to create files
• Disallow to create Public Content

==> It's still possible to change visibility to public in the File module dialogs

[yurabakhtin]

@luke- Fixed in core PR humhub/humhub#6836

[luke-]

@yurabakhtin Does this checkbox really executes the core toggle action?

[yurabakhtin]

@luke- This checkbox is visible only when content can be stored as public:

for space with only private content it is hidden:

In the PR humhub/humhub#6836 I have fixed a case when space visibility is updated to Private, but some page with files list was not reloaded yet, so the menu item "Change to Public" is still visible and it was possible update such file to Public, now it is fixed with this way:

Was the bug fixed or I miss something?

[luke-]

@yurabakhtin Hmm, I think you missed something.

Set "CreatePublicContent" to "Deny" for regular Space Members

Login as "Regular Member".

Upload a "File".

The context menu is correct, the Change to "Public" option is not available:

When click on "Edit". The option is available:

[yurabakhtin]

@luke- Thanks for the additional info. Fixed in PR humhub/humhub#6837.

[luke-]

@yurabakhtin Can you please check the failing tests? Maybe also some tests would be great here.

[yurabakhtin]

@luke- The tests have been fixed. I don't think we need additional tests because at least this test testCreatePublicContentOnPrivateSpace does it.