Skip to content

Commit

Permalink
fixup! Code deduplication by introducing `PermissionManager::handlePe…
Browse files Browse the repository at this point in the history
…rmissionStateChange()`
  • Loading branch information
martin-rueegg committed Dec 16, 2023
1 parent 04838f2 commit 95ad6c7
Showing 1 changed file with 4 additions and 14 deletions.
18 changes: 4 additions & 14 deletions protected/humhub/modules/admin/controllers/SpaceController.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,15 @@
namespace humhub\modules\admin\controllers;

use humhub\modules\admin\models\SpaceSearch;
use humhub\modules\admin\permissions\ManageSettings;
use humhub\modules\admin\permissions\ManageSpaces;
use humhub\modules\content\components\ContentContainerDefaultPermissionManager;
use humhub\modules\content\models\Content;
use humhub\modules\space\models\Space;
use humhub\modules\space\Module;
use humhub\modules\user\helpers\AuthHelper;
use Yii;
use humhub\modules\admin\components\Controller;
use humhub\modules\admin\permissions\ManageSpaces;
use humhub\modules\admin\permissions\ManageSettings;
use yii\web\HttpException;

/**
Expand All @@ -27,7 +27,6 @@
*/
class SpaceController extends Controller
{

/**
* @inheritdoc
*/
Expand Down Expand Up @@ -164,21 +163,12 @@ public function actionPermissions()
}

// Handle permission state change
if (Yii::$app->request->post('dropDownColumnSubmit')) {
Yii::$app->response->format = 'json';
$permission = $defaultPermissionManager->getById(Yii::$app->request->post('permissionId'), Yii::$app->request->post('moduleId'));
if ($permission === null) {
throw new HttpException(500, 'Could not find permission!');
}
$defaultPermissionManager->setGroupState($groupId, $permission, Yii::$app->request->post('state'));
return [];
}
$return = $defaultPermissionManager->handlePermissionStateChange($groupId);

return $this->render('permissions', [
return $return ?? $this->render('permissions', [
'defaultPermissionManager' => $defaultPermissionManager,
'groups' => $groups,
'groupId' => $groupId,
]);
}

}

0 comments on commit 95ad6c7

Please sign in to comment.