is this an OnUserDelete bug in NotificationModule.php?

[alirezastack]

In the onUserDelete() function in NotificationModule we have two codes as below:

    foreach (Notification::model()->findAllByAttributes(array('user_id' => $event->sender->id)) as $notification) {
        $notification->delete();
    }

    foreach (Notification::model()->findAllByAttributes(array('source_object_model' => 'User', 'user_id' => $event->sender->id)) as $notification) {
        $notification->delete();
    }

When the first loop iterates through Notifs and delete them all. We don't have Notifs with the same user_id for the second loop. It seems that second one is useless!? Correct me if I'm wrong.

Cheers

[alirezastack]

So the part " 'source_object_model' => 'User' " doesn't do anything as we don't have user.

[luke-]

Yes, thank you! Second attribute should be "source_object_id' => $event->sender->id