Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only render topic chooser if there are topics available or user can create topics. #4213

Closed
buddh4 opened this issue Jul 10, 2020 · 0 comments
Closed

Only render topic chooser if there are topics available or user can create topics. #4213

buddh4 opened this issue Jul 10, 2020 · 0 comments
Assignees
@buddh4
Labels
Kind:Enhancement Topic:Topics Topic:Usability
Milestone
v1.6

Comments

@buddh4
Copy link
Contributor

buddh4 commented Jul 10, 2020

Currently the topic chooser is rendered for users who can not create topics even if there are not topics available.
@buddh4 buddh4 self-assigned this Jul 10, 2020
@buddh4 buddh4 added this to the v1.6 milestone Jul 10, 2020
buddh4 added a commit that referenced this issue Jul 10, 2020
@buddh4
- Enh #4213: Only render topic chooser if there are topics available …
3e73691 
…or user can create topics

- Enh: Added `humhub\modules\ui\form\widgets\ActiveField:preventRendering` to manage render state within field classes
- Enh: Added `humhub\modules\ui\form\widgets\JsInputWidget:emptyResult()` helper to manage render state of JsInputWidget
- Enh: Added `humhub\modules\ui\form\widgets\JsInputWidget:field` in order to access ActiveField instances within JsInputWidget
buddh4 added a commit that referenced this issue Jul 10, 2020
@buddh4
- Enh #4213: Only render topic chooser if there are topics available …
9ef6987 
…or user can create topics

- Enh: Added `humhub\modules\ui\form\widgets\ActiveField:preventRendering` to manage render state within field classes
- Enh: Added `humhub\modules\ui\form\widgets\JsInputWidget:emptyResult()` helper to manage render state of JsInputWidget
- Enh: Added `humhub\modules\ui\form\widgets\JsInputWidget:field` in order to access ActiveField instances within JsInputWidget
buddh4 added a commit that referenced this issue Jul 10, 2020
@buddh4
Merge pull request #4214 from humhub/enh/4213
90f5b63 
- Enh #4213: Only render topic chooser if there are topics available …
@buddh4 buddh4 closed this as completed Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@buddh4 buddh4

Labels
Kind:Enhancement Topic:Topics Topic:Usability
Projects
None yet
Milestone
v1.6
Development

No branches or pull requests
1 participant
@buddh4