Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the container header clickable to return to the container's home #6686

Closed
marc-farre opened this issue Nov 29, 2023 · 6 comments
Closed

Comments

@marc-farre
Copy link
Collaborator

marc-farre commented Nov 29, 2023

Is your feature request related to a problem? Please describe.

When we want to go back to the Homepage, we instinctively click on the logo.
In a container (Space or User), clicking on it displays it in full screen.

But we could make the rest of the banner clickable.

Describe the solution you'd like

When clicking here we go back to the container's homepage:
image

This should be possible only for non admins, because admins needs to click on it on touch screen to change the banner's logo.
For admins, we could add the link to the container's homepage only the container's name and description text.

Describe alternatives you've considered

For both admins and non admin, only the text is clickable.

@marc-farre
Copy link
Collaborator Author

@luke- if you agree, I can make a PR

@luke-
Copy link
Contributor

luke- commented Nov 29, 2023

@marc-farre Perhaps it is better to make only the text clickable, as this could cause problems on mobile devices, for example?

@Eladnarlea What do you think?

@ArchBlood
Copy link
Contributor

I believe we should also think of refactoring the whole containerProfileHeader, currently as seen in the Verified module, you can't easily interact within this without view manipulation, and if you have multiple modules or themes doing this then only one will actually take effect.
I'd also like to mention how stressful it is that if you try interacting with the title, such as clicking, the profile banner is interacted with, this isn't optimal.

@marc-farre
Copy link
Collaborator Author

@Eladnarlea do you agree if these text become clickable (link to the space home)?
image
Thanks!

@Eladnarlea
Copy link

@marc-farre we can do that, yes. But only the header, in this case General Discussion -right?

@marc-farre
Copy link
Collaborator Author

@Eladnarlea Thanks. So the space description (second rectangle on my screenshot) is not clickable.

@luke- PR #6732

@luke- luke- closed this as completed Dec 13, 2023
github-merge-queue bot pushed a commit that referenced this issue Dec 13, 2023
…iner's home (#6732)

Co-authored-by: Lucas Bartholemy <luke-@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants