New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the container header clickable to return to the container's home #6686
Comments
@luke- if you agree, I can make a PR |
@marc-farre Perhaps it is better to make only the text clickable, as this could cause problems on mobile devices, for example? @Eladnarlea What do you think? |
I believe we should also think of refactoring the whole containerProfileHeader, currently as seen in the Verified module, you can't easily interact within this without view manipulation, and if you have multiple modules or themes doing this then only one will actually take effect. |
@Eladnarlea do you agree if these text become clickable (link to the space home)? |
@marc-farre we can do that, yes. But only the header, in this case |
@Eladnarlea Thanks. So the space description (second rectangle on my screenshot) is not clickable. |
…iner's home (#6732) Co-authored-by: Lucas Bartholemy <luke-@users.noreply.github.com>
Is your feature request related to a problem? Please describe.
When we want to go back to the Homepage, we instinctively click on the logo.
In a container (Space or User), clicking on it displays it in full screen.
But we could make the rest of the banner clickable.
Describe the solution you'd like
When clicking here we go back to the container's homepage:
This should be possible only for non admins, because admins needs to click on it on touch screen to change the banner's logo.
For admins, we could add the link to the container's homepage only the container's name and description text.
Describe alternatives you've considered
For both admins and non admin, only the text is clickable.
The text was updated successfully, but these errors were encountered: