New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow theme without second topbar menu #6725
Comments
@luke- would you accept a PR where I add tests in |
@marc-farre Yes, would be fine for me. So feel free to create a PR which tests if the second toolbar exists. |
I've changed the way of calculating the topbar menus height: https://github.com/humhub/humhub/pull/6728/files#diff-b154946f00749e44d107396a9627ecd5987a0bab499487d466968f514df4bdc3R163-R168 Before: Position of the second menu from the top + height of the second menu |
@marc-farre Looks fine for me. Thanks! |
Is your feature request related to a problem? Please describe.
#topbar-second
element, e.g. the Clean Theme.Uncaught TypeError: Cannot read properties of undefined (reading 'offsetHeight')
The problem is because of
$topBarSecond[0].offsetHeight
here: https://github.com/humhub/humhub/blob/master/static/js/humhub/humhub.ui.topNavigation.js#L52C42-L52C71Describe the solution you'd like
Test if
#topbar-second
exists before reading it with JS.The text was updated successfully, but these errors were encountered: